Prevent printing metadata block twice #271
Conversation
| select_group(metadata_info[block_i++], true); | ||
| info_metadata(block.get(), true); | ||
| if (first_block->next_block_rel != 0) { // if there is more than one block | ||
| auto all_blocks = get_all_blocks(bin, raw_access.get_binary_start(), first_block, more_cb); |
There was a problem hiding this comment.
Hmmm, does this change imply that if there are two or more blocks, then get_all_blocks doesn't return the first block; but if there's only one block, then get_all_blocks does return the first block??
Or am I just mis-reading the diff?
There was a problem hiding this comment.
Yes, get_all_blocks returns all other blocks when there are multiple blocks, but it returns the first block again if there is only one block
There was a problem hiding this comment.
This might be a stupid question (I'm good a those 😆 ), but I wonder if that suggests that get_all_blocks should instead return zero blocks if there is only one block? Seems like it might be more consistent behaviour? 🤷♂️
There was a problem hiding this comment.
That's probably for another PR, as I'd need to fix some places it's used so that behaviour works
There was a problem hiding this comment.
Fair enough; not being familiar with the code, I didn't realise that you were relying on the existing behaviour in other places.
|
Maybe it's worth adding a regression-test for this to CI? 🤔 |
That'd probably be a separate PR, to add regression testing to the |
Prevent printing metadata block twice in
picotool info, when only one block is present in the block loopNoticed in #270
Before:
After: